This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros - Package must not depend on deprecated() packages. Note: libdb is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/jabberd See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "FSF All Permissive License", "GNU General Public License v2.0 or later", "FSF Unlimited License (with License Retention) and/or GNU General Public License v3.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "Kevlin Henney License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "PostgreSQL License", "BSD 4-Clause License", "Apache License 1.0 and/or BSD 4-Clause License", "ISC License", "Public domain", "BSD 3-Clause License", "*No copyright* Public domain", "zlib License", "Mozilla Public License 1.1", "GNU General Public License", "*No copyright* Apache License 2.0", "MIT License", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]". 560 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/jabberd/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 47989 bytes in 7 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in jabberd [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [ ]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: jabberd-2.6.1-32.fc43.x86_64.rpm jabberd-2.6.1-32.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpu57nwvf5')] checks: 32, packages: 2 jabberd.x86_64: E: zero-length /etc/jabberd/server.pem jabberd.src: E: spelling-error ('pam', '%description -l en_US pam -> map, Pam, pan') jabberd.src: E: spelling-error ('sqlite', '%description -l en_US sqlite -> sq lite, sq-lite, SQLite') jabberd.x86_64: E: spelling-error ('pam', '%description -l en_US pam -> map, Pam, pan') jabberd.x86_64: E: spelling-error ('sqlite', '%description -l en_US sqlite -> sq lite, sq-lite, SQLite') jabberd.x86_64: W: non-standard-uid /etc/jabberd jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/c2s.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/c2s.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router-filter.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router-filter.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router-users.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router-users.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/router.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/s2s.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/s2s.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/sm.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/sm.xml.dist jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/templates jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/templates/roster.xml jabber jabberd.x86_64: W: non-standard-uid /etc/jabberd/templates/roster.xml.dist jabber jabberd.x86_64: W: non-standard-uid /var/lib/jabberd jabber jabberd.x86_64: W: non-standard-uid /var/lib/jabberd/db jabber jabberd.x86_64: W: non-standard-uid /var/lib/jabberd/log jabber jabberd.x86_64: W: non-standard-uid /var/lib/jabberd/pid jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/c2s.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/c2s.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router-filter.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router-filter.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router-users.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router-users.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/router.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/s2s.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/s2s.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/sm.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/sm.xml.dist jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/templates jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/templates/roster.xml jabber jabberd.x86_64: W: non-standard-gid /etc/jabberd/templates/roster.xml.dist jabber jabberd.x86_64: W: non-standard-gid /var/lib/jabberd jabber jabberd.x86_64: W: non-standard-gid /var/lib/jabberd/db jabber jabberd.x86_64: W: non-standard-gid /var/lib/jabberd/log jabber jabberd.x86_64: W: non-standard-gid /var/lib/jabberd/pid jabber jabberd.x86_64: E: non-standard-dir-perm /etc/jabberd 750 jabberd.x86_64: E: non-standard-dir-perm /etc/jabberd/templates 750 jabberd.x86_64: E: non-readable /etc/jabberd/c2s.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/c2s.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/router-filter.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/router-filter.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/router-users.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/router-users.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/router.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/router.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/s2s.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/s2s.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/sm.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/sm.xml.dist 640 jabberd.x86_64: E: non-readable /etc/jabberd/templates/roster.xml 640 jabberd.x86_64: E: non-readable /etc/jabberd/templates/roster.xml.dist 640 jabberd.x86_64: E: non-executable-script /usr/share/jabberd/bdb2mysql.rb 644 /usr/bin/ruby jabberd.x86_64: E: non-executable-script /usr/share/jabberd/bdbdump.pl 644 /usr/bin/perl -w jabberd.x86_64: E: non-executable-script /usr/share/jabberd/jabberd 644 /usr/bin/sh jabberd.x86_64: E: non-executable-script /usr/share/jabberd/jabberd-authpipe-pam-0.1.pl 644 /usr/bin/perl -w jabberd.x86_64: E: non-executable-script /usr/share/jabberd/migrate-jd14dir-2-sqlite.pl 644 /usr/bin/perl -w jabberd.x86_64: E: non-executable-script /usr/share/jabberd/migrate.pl 644 /usr/bin/perl -w jabberd.x86_64: E: non-executable-script /usr/share/jabberd/pipe-auth.pl 644 /usr/bin/perl -w jabberd.spec: W: no-%check-section jabberd.x86_64: E: incorrect-fsf-address /usr/share/doc/jabberd/COPYING jabberd.x86_64: W: files-duplicate /etc/jabberd/c2s.xml.dist /etc/jabberd/c2s.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/router-filter.xml.dist /etc/jabberd/router-filter.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/router-users.xml.dist /etc/jabberd/router-users.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/router.xml.dist /etc/jabberd/router.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/s2s.xml.dist /etc/jabberd/s2s.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/sm.xml.dist /etc/jabberd/sm.xml jabberd.x86_64: W: files-duplicate /etc/jabberd/templates/roster.xml.dist /etc/jabberd/templates/roster.xml jabberd.x86_64: E: file-parent-ownership-mismatch Path "/etc/jabberd/server.pem" owned by "root" is stored in directory owned by "jabber" jabberd.x86_64: W: devel-file-in-non-devel-package /usr/lib64/jabberd/libstorage.so jabberd.x86_64: W: dangerous-command-in-%post chown 2 packages and 0 specfiles checked; 30 errors, 50 warnings, 13 filtered, 30 badness; has taken 1.3 s Rpmlint (debuginfo) ------------------- Checking: jabberd-debuginfo-2.6.1-32.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3qwef3lc')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 102 filtered, 0 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "jabberd-debuginfo". (none): E: there is no installed rpm "jabberd". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- jabberd: /usr/lib64/jabberd/authreg_anon.so jabberd: /usr/lib64/jabberd/authreg_db.so jabberd: /usr/lib64/jabberd/authreg_ldap.so jabberd: /usr/lib64/jabberd/authreg_ldapfull.so jabberd: /usr/lib64/jabberd/authreg_mysql.so jabberd: /usr/lib64/jabberd/authreg_pam.so jabberd: /usr/lib64/jabberd/authreg_pgsql.so jabberd: /usr/lib64/jabberd/authreg_pipe.so jabberd: /usr/lib64/jabberd/authreg_sqlite.so jabberd: /usr/lib64/jabberd/libstorage.so jabberd: /usr/lib64/jabberd/mod_active.so jabberd: /usr/lib64/jabberd/mod_amp.so jabberd: /usr/lib64/jabberd/mod_announce.so jabberd: /usr/lib64/jabberd/mod_deliver.so jabberd: /usr/lib64/jabberd/mod_disco.so jabberd: /usr/lib64/jabberd/mod_echo.so jabberd: /usr/lib64/jabberd/mod_help.so jabberd: /usr/lib64/jabberd/mod_iq-last.so jabberd: /usr/lib64/jabberd/mod_iq-ping.so jabberd: /usr/lib64/jabberd/mod_iq-private.so jabberd: /usr/lib64/jabberd/mod_iq-time.so jabberd: /usr/lib64/jabberd/mod_iq-vcard.so jabberd: /usr/lib64/jabberd/mod_iq-version.so jabberd: /usr/lib64/jabberd/mod_offline.so jabberd: /usr/lib64/jabberd/mod_pep.so jabberd: /usr/lib64/jabberd/mod_presence.so jabberd: /usr/lib64/jabberd/mod_privacy.so jabberd: /usr/lib64/jabberd/mod_roster-publish.so jabberd: /usr/lib64/jabberd/mod_roster.so jabberd: /usr/lib64/jabberd/mod_session.so jabberd: /usr/lib64/jabberd/mod_status.so jabberd: /usr/lib64/jabberd/mod_template-roster.so jabberd: /usr/lib64/jabberd/mod_vacation.so jabberd: /usr/lib64/jabberd/mod_validate.so jabberd: /usr/lib64/jabberd/mod_verify.so jabberd: /usr/lib64/jabberd/storage_db.so jabberd: /usr/lib64/jabberd/storage_fs.so jabberd: /usr/lib64/jabberd/storage_ldapvcard.so jabberd: /usr/lib64/jabberd/storage_mysql.so jabberd: /usr/lib64/jabberd/storage_pgsql.so jabberd: /usr/lib64/jabberd/storage_sqlite.so Source checksums ---------------- https://github.com/jabberd2/jabberd2/releases/download/jabberd-2.6.1/jabberd-2.6.1.tar.xz : CHECKSUM(SHA256) this package : c22d45bd4105b344351cbbfd6da99755182f64120747d18e91b6267a73775099 CHECKSUM(SHA256) upstream package : c22d45bd4105b344351cbbfd6da99755182f64120747d18e91b6267a73775099 Requires -------- jabberd (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl /usr/bin/ruby /usr/bin/sh config(jabberd) group(jabber) libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libdb-5.3.so()(64bit) libexpat.so.1()(64bit) libgsasl.so.7()(64bit) libgsasl.so.7(LIBGSASL_1.1)(64bit) libhttp_parser.so.2()(64bit) libidn.so.12()(64bit) libidn.so.12(LIBIDN_1.0)(64bit) liblber.so.2()(64bit) liblber.so.2(OPENLDAP_2.200)(64bit) libldap.so.2()(64bit) libldap.so.2(OPENLDAP_2.200)(64bit) libmariadb.so.3()(64bit) libmariadb.so.3(libmysqlclient_18)(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpq.so.5()(64bit) libpq.so.5(RHPG_9.6)(64bit) libsqlite3.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstorage.so.0()(64bit) libudns.so.0()(64bit) libz.so.1()(64bit) openssl perl(Authen::PAM) perl(BerkeleyDB) perl(DBI) perl(Data::Dumper) perl(Digest::SHA1) perl(Getopt::Long) perl(MIME::Base64) perl(Net::Jabber) perl(XML::Simple) perl(strict) rtld(GNU_HASH) shadow-utils systemd-sysv systemd-units user(jabber) Provides -------- jabberd: config(jabberd) group(jabber) jabberd jabberd(x86-64) libstorage.so.0()(64bit) user(jabber) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: jabberd-2.6.1-build/jabberd-2.6.1/configure.ac:22 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name jabberd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api, Perl Disabled plugins: R, Python, Java, SugarActivity, PHP, fonts, Ocaml, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH