{"object_kind":"push","event_name":"push","before":"2de6391f4bc90158fd9cba8ef65a5fbaadb3c34f","after":"9bbb1139872b6a3cb21e1c08c7853057b4ee2674","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"9bbb1139872b6a3cb21e1c08c7853057b4ee2674","message":null,"user_id":1031,"user_name":"Lubomir Rintel","user_username":"lkundrak","user_email":"","user_avatar":"https://secure.gravatar.com/avatar/0c78b09297e4f43bda3282627ada927e031aabd945d9a02df75ae525a18952a8?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"9bbb1139872b6a3cb21e1c08c7853057b4ee2674","message":"device: don't disable IPv6 in stage3 on reapply\n\nCurrently, when a call to Reapply() results in stage3 being re-run, IPv6\nends up messed up. Like this:\n\n  $ nmcli device modify eth0 ipv4.address ''\n  $ nmcli device modify eth0 ipv4.address 172.31.13.37/24\n  $\n\n  NetworkManager[666]: <debug> [1751286095.2070] device[c95ca04a69467d81] (eth0): ip4: reapply...\n  ...\n  NetworkManager[666]: <debug> [1751286095.2104] device[c95ca04a69467d81] (eth0): ip6: addrgenmode6: set none (already set)\n  NetworkManager[666]: <debug> [1751286095.2105] device[c95ca04a69467d81] (eth0): ip6: addrgenmode6: toggle disable_ipv6 sysctl after disabling addr-gen-mode\n  NetworkManager[666]: <debug> [1751286095.2105] platform-linux: sysctl: setting '/proc/sys/net/ipv6/conf/eth0/disable_ipv6' to '1' (current value is '0')\n  NetworkManager[666]: <debug> [1751286095.2106] platform-linux: sysctl: setting '/proc/sys/net/ipv6/conf/eth0/disable_ipv6' to '0' (current value is '1')\n  NetworkManager[666]: <debug> [1751286095.2106] platform-linux: sysctl: setting '/proc/sys/net/ipv6/conf/eth0/accept_ra' to '0' (current value is identical)\n  NetworkManager[666]: <debug> [1751286095.2106] platform-linux: sysctl: setting '/proc/sys/net/ipv6/conf/eth0/disable_ipv6' to '0' (current value is identical)\n\nNot only is this unnecessary because addr-gen-mode already has the\ndesired value (as is logged), but also wipes off all IPv6 configuration.\nThis is fine on initial configuration, but not on Reapply().\n\nLet's look at the device state first: if we've progressed past ip-config\nstate, then we can't possibly ever touch the offending sysctls. It's\nokay -- we don't need to: addr-gen-mode is going to be set right if we\nwent through ip-config before.\n\nResolves: https://issues.redhat.com/browse/NMT-1681\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2232\n","title":"device: don't disable IPv6 in stage3 on reapply","timestamp":"2025-07-07T15:38:51+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9bbb1139872b6a3cb21e1c08c7853057b4ee2674","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]}],"total_commits_count":1,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}