{"object_kind":"push","event_name":"push","before":"892e816a9defd82406ca597ef0d826c3f183f92a","after":"fd3eccfb1612a3bac87232e1cbaabc10da80c302","ref":"refs/heads/main","ref_protected":false,"checkout_sha":"fd3eccfb1612a3bac87232e1cbaabc10da80c302","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"fd3eccfb1612a3bac87232e1cbaabc10da80c302","message":"device: update the external-down unmanaged flag on port attach/release\n\nA device has the \"external-down\" unmanaged flag when:\n\n  !is-created-by-nm AND (!is-up OR (!has-address AND !is-controller))\n\nWhen the \"is-up\" or the \"has-address\" conditions change, we properly update\nthe unmanaged flag by calling _dev_unmanaged_check_external_down() in\n_dev_l3_cfg_notify_cb(PLATFORM_CHANGE_ON_IDLE).\n\nThe \"is-controller\" condition changes when another link indicates the\ncurrent device as controller. We currently don't update the unmanaged flag\nwhen that happens and so it's possible that the device stays unmanaged even\nif it has a port. This can be easily reproduced by running this commands:\n\n    ip link add veth0 type veth peer name veth1\n    ip link add vrf0 type vrf table 10\n    ip link set vrf0 up\n    ip link set veth0 master vrf0\n\nSometimes, the device shows as \"unmanaged\" instead of \"connected\n(externally)\".\n\nFix this by re-evaluating the \"external-down\" unmanaged flags on the\ncontroller when a port is attached or detached.\n\nFixes: c3586ce01a5b ('device: consider a device with slaves configured')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2209\n","title":"device: update the external-down unmanaged flag on port attach/release","timestamp":"2025-05-15T17:22:39+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fd3eccfb1612a3bac87232e1cbaabc10da80c302","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]}],"total_commits_count":1,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}