{"object_kind":"push","event_name":"push","before":"8caccc6bed0b56528ef3d880af1c217bb8d24419","after":"ce95405af995749273e99868a6fea2d7bca62499","ref":"refs/heads/nm-1-54","ref_protected":false,"checkout_sha":"ce95405af995749273e99868a6fea2d7bca62499","message":null,"user_id":1050,"user_name":"Beniamino Galvani","user_username":"bgalvani","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/1050/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"22402be8c4989d77188748d61bec8ca41ca1249d","message":"libnm-core: fix the documentation of the gateway IP property\n\nThe D-Bus API documentation of the IPv4 and IPv6 settings say:\n\n* addresses\n \tDeprecated in favor of the 'address-data' and 'gateway'\n \tproperties, but this can be used for backward-compatibility\n \twith older daemons. Note that if you send this property the\n \tdaemon will ignore 'address-data' and 'gateway'.\n\n* gateway\n       The gateway associated with this configuration. This is only\n       meaningful if \"addresses\" is also set.\n\nThis documentation wrongly suggests that at D-Bus level \"gateway\"\nrequires \"addresses\", while it actually requires \"address-data\". The\nreason for the inconsistency is that the gateway documentation is\ncommon between nmcli and D-Bus and it refers to the \"address\" GObject\nproperty, not to the D-Bus property.\n\nFix this inconsistency by not explicitly mentioning the property name.\n\nFixes: 36156b70dc06 ('libnm: Override parts of nm-setting-docs.xml')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2319\n(cherry picked from commit dad4da06b1e00ea04145f12268e2345af74ba4e3)\n(cherry picked from commit 102c763348f912e4984f4946c97e3ee18705f938)\n","title":"libnm-core: fix the documentation of the gateway IP property","timestamp":"2025-12-17T13:16:34+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/22402be8c4989d77188748d61bec8ca41ca1249d","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-ip-config.c","src/libnmc-setting/settings-docs.h.in","src/nmcli/gen-metadata-nm-settings-nmcli.xml.in"],"removed":[]},{"id":"88d87f7b2a29d8984048f1d1021d98a3cc0e1e24","message":"nmcli: fix \"device wifi connect\" command with existing connection\n\nExecuting this command twice, or when a connection profile already\nexists for the SSID:\n\n  nmcli device wifi connect $SSID password $PASSWORD\n\nreturns error:\n\n  Error: 802-11-wireless-security.key-mgmt: property is missing.\n\nWhen setting the password nmcli was wiping the existing wireless\nsecurity setting.\n\nFixes: c8ff1b30fba3 ('nmcli/dev: use secret agent for nmcli d [wifi] connect')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1688\n(cherry picked from commit 3a4e18e30205b958ced44382313586e6858cc027)\n(cherry picked from commit 50387acd4b753015903a573877e0bd19d8fb2131)\n","title":"nmcli: fix \"device wifi connect\" command with existing connection","timestamp":"2025-12-17T13:16:36+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/88d87f7b2a29d8984048f1d1021d98a3cc0e1e24","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/devices.c"],"removed":[]},{"id":"ce95405af995749273e99868a6fea2d7bca62499","message":"nmcli: start the agent only after updating the connection\n\nWhen connecting to a wifi network and providing the password on the\ncommand line, nmcli first looks if there is a compatible connection to\nreuse. If there is not, it creates and activates a new one via a\nsingle call to AddAndActivate().\n\nIf there is a compatible connection, nmcli first calls Update() on it\nto set the new password and then Activate() to bring it up. Before\nthat, it registers a secret agent that can prompt for a new password\nin case of authentication failure.\n\nHowever, as soon as nmcli registers a secret agent, NM tries to\nactivate again the connection if it was blocked due to a previous\nauthentication failure. This connection attempt is going to fail\nbecause it still uses the old password, as new one hasn't been set via\nUpdate().\n\nChange the order of operations to register the agent after Update()\nand before Activate().\n\nReproducer:\n\n nmcli device wifi connect SSID password BAD_PASSWORD\n nmcli device wifi connect SSID password GOOD_PASSWORD\n\nFixes: c8ff1b30fba3 ('nmcli/dev: use secret agent for nmcli d [wifi] connect')\n(cherry picked from commit 427a7cf2577868cd70556923a88312a68f939009)\n(cherry picked from commit d399ffbaba325df1b749d23c2f2fcba8ef8646cf)\n","title":"nmcli: start the agent only after updating the connection","timestamp":"2025-12-17T13:16:37+01:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ce95405af995749273e99868a6fea2d7bca62499","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/devices.c"],"removed":[]}],"total_commits_count":3,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}