{"object_kind":"push","event_name":"push","before":"d16a62da2b0f6dc11c35b734d9081e943dc7f9c4","after":"4a300d7b8388e535677f1079779fb42f7f8d2ecb","ref":"refs/heads/nm-1-54","ref_protected":false,"checkout_sha":"4a300d7b8388e535677f1079779fb42f7f8d2ecb","message":null,"user_id":5899,"user_name":"Filip Pokryvka","user_username":"fpokryvk","user_email":"","user_avatar":"https://gitlab.freedesktop.org/uploads/-/system/user/avatar/5899/avatar.png","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"47a6463559120fc1fccf44f67412df9bc4c10902","message":"nmcli: fix compile error\n\nRunning the build script with LTO disabled\n(\"contrib/fedora/rpm/build_clean.sh -W lto\") gives the following error:\n\n  In file included from ../src/libnm-std-aux/nm-default-std.h:102,\n                   from ../src/libnm-glib-aux/nm-default-glib.h:11,\n                   from ../src/libnm-glib-aux/nm-default-glib-i18n-lib.h:13,\n                   from ../src/libnm-client-aux-extern/nm-default-client.h:11,\n                   from ../src/nmcli/connections.c:6:\n  In function ‘_nm_auto_unref_ptrarray’,\n      inlined from ‘do_connection_add’ at ../src/nmcli/connections.c:6069:35:\n  ../src/libnm-std-aux/nm-std-aux.h:1106:12: error: ‘props’ may be used uninitialized [-Werror=maybe-uninitialized]\n   1106 |         if (*v)                               \\\n        |            ^\n  ../src/libnm-glib-aux/nm-macros-internal.h:91:1: note: in expansion of macro ‘NM_AUTO_DEFINE_FCN0’\n     91 | NM_AUTO_DEFINE_FCN0(GPtrArray *, _nm_auto_unref_ptrarray, g_ptr_array_unref);\n        | ^~~~~~~~~~~~~~~~~~~\n  ../src/nmcli/connections.c: In function ‘do_connection_add’:\n  ../src/nmcli/connections.c:6069:35: note: ‘props’ was declared here\n   6069 |     gs_unref_ptrarray GPtrArray  *props;\n        |                                   ^~~~~\n  cc1: all warnings being treated as errors\n\nFix it.\n\nFixes: bb850fda0ed9 ('nmcli: connection: process port-type, type and controller first')\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2236\n","title":"nmcli: fix compile error","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/47a6463559120fc1fccf44f67412df9bc4c10902","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nmcli/connections.c"],"removed":[]},{"id":"04abe0aeb49f9af4903777b10b0aacd2e801ad1b","message":"bond: fix attribute assignment macro\n\nCurrently the bug is hidden because the macro is only called with\nNM_SETTING_BOND_OPTION_ARP_IP_TARGET.\n\nFixes: 45c95e9314cd ('device/bond: rework setting of arp_ip_target bond options')\n","title":"bond: fix attribute assignment macro","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/04abe0aeb49f9af4903777b10b0aacd2e801ad1b","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-bond.c"],"removed":[]},{"id":"9f2cd88cad93201aad7c6d0386b57288820b83b2","message":"core: fix properties update for HSR devices\n\nFixes: 5426bdf4a122 ('HSR: add support to HSR/PRP interface')\n","title":"core: fix properties update for HSR devices","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9f2cd88cad93201aad7c6d0386b57288820b83b2","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-hsr.c"],"removed":[]},{"id":"cb362906387dcc418a18f5d2326ce9156bae0f8d","message":"ovs: fix logging message\n\nFixes: a259303e1d5a ('ovs: add support for \"other_config\" settings')\n","title":"ovs: fix logging message","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/cb362906387dcc418a18f5d2326ce9156bae0f8d","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/ovs/nm-ovsdb.c"],"removed":[]},{"id":"dd2ddb23282479afd8f5ca02ede9a6a42f4a43db","message":"libnm-core,core: accept uid/gid up to (2^32 - 2) for tun devices\n\nLinux UIDs/GIDs are 32-bit unsigned integer, with 4294967295 reserved\nas undefined.\n\nBefore:\n  # useradd -u 4294967294 -M testuser\n  useradd warning: testuser's uid -2 outside of the UID_MIN 1000 and UID_MAX 60000 range.\n  # nmcli connection add type tun ifname tun1 owner 4294967294 ipv4.method disabled ipv6.method disabled\n  Error: Failed to add 'tun-tun1' connection: tun.owner: '4294967294': invalid user ID\n\nAfter:\n  # useradd -u 4294967294 -M testuser\n  useradd warning: testuser's uid -2 outside of the UID_MIN 1000 and UID_MAX 60000 range.\n  # nmcli connection add type tun ifname tun1 owner 4294967294 ipv4.method disabled ipv6.method disabled\n  Connection 'tun-tun1' (5da24d19-1723-45d5-8e04-c976f7a251d0) successfully added.\n  # ip -d link show tun1\n  2421: tun1: <NO-CARRIER,POINTOPOINT,MULTICAST,NOARP,UP> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 500\n      link/none  promiscuity 0 allmulti 0 minmtu 68 maxmtu 65535\n      tun type tun pi off vnet_hdr off persist on user testuser ...\n                                                 ^^^^^^^^^^^^^\nFixes: 1f30147a7a83 ('libnm-core: add NMSettingTun')\n","title":"libnm-core,core: accept uid/gid up to (2^32 - 2) for tun devices","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/dd2ddb23282479afd8f5ca02ede9a6a42f4a43db","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-tun.c","src/libnm-core-impl/nm-setting-tun.c"],"removed":[]},{"id":"e1eacfc28972aa3c05be5cf9003949cb4326423d","message":"supplicant: fix wrong check on \"EAP\" signal arguments\n\nThe check is inverted.\n\nFixes: b83f07916a54 ('supplicant: large rework of wpa_supplicant handling')\n","title":"supplicant: fix wrong check on \"EAP\" signal arguments","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/e1eacfc28972aa3c05be5cf9003949cb4326423d","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/supplicant/nm-supplicant-interface.c"],"removed":[]},{"id":"c819afcf460cd5c93e2efd2091682a8f0621189e","message":"lldp: fix memchr() argument order\n\nThe validation of embedded NUL character was skipped due to the wrong\norder of arguments to memchr(). Fix it.\n\nFixes: 4043f8279003 ('lldp: cleanup converting binary LLDP fields to string')\n","title":"lldp: fix memchr() argument order","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c819afcf460cd5c93e2efd2091682a8f0621189e","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-lldp-listener.c"],"removed":[]},{"id":"c4e803e941e661588442451d7c6418fa67373253","message":"vrf: fix wrong logging domain\n\nFixes: 667568d1b2be ('core,libnm: add VRF support')\n","title":"vrf: fix wrong logging domain","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c4e803e941e661588442451d7c6418fa67373253","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-vrf.c"],"removed":[]},{"id":"1ea52a06110841713490df0fb6804472548820d5","message":"bond-slb: fix memory leak\n\nIf sendto() fails, the function returns and the remaining entries are\nnot deallocated. Use nm_auto_freev instead to free the array and the\npointer it contains.\n\nAdd a test to check that nm_auto_freev does the right thing on the\nvalue returned by nm_linux_platform_get_bridge_fdb().\n\nFixes: 3f2f922dd943 ('bonding: send ARP announcement on bonding-slb link/carrier down')\n","title":"bond-slb: fix memory leak","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/1ea52a06110841713490df0fb6804472548820d5","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-bond-manager.c","src/core/platform/tests/test-link.c"],"removed":[]},{"id":"67f382b7adabf8a9d8955c6c91a141e9ad322f11","message":"dhcp: fix typo in tcp_keepalive_interval option name\n\nFixes: eed205bff317 ('dhcp/internal: move dhcp options management to shared dhcp codebase')\n","title":"dhcp: fix typo in tcp_keepalive_interval option name","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/67f382b7adabf8a9d8955c6c91a141e9ad322f11","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/dhcp/nm-dhcp-options.c"],"removed":[]},{"id":"dc3bb22633b970a87439851b9b303d56ed3c828b","message":"dhcp: fix parsing of the search list option\n\nThe DHCP search list option (119) can use the \"message compression\"\nalgorithm specified in RFC 1035 section 4.1.4 to reduce the size of\nthe message in presence of subdomains that appear multiple times.\n\nWhen using the compression a label starts with:\n\n    +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+\n    | 1  1|                OFFSET                   |\n    +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+\n\nwhere the offset points to a previous domain.\n\nPreviously, the parsing code was taking the lower 6 bits of the first\nbyte, shifting them left 16 bits, and adding the next byte. Instead,\nthe shift should be of 8 bits.\n\nThe effect of this bug was that when the offset was greater than 255,\nit was incorrectly parsed as a number larger than the message size,\nand the parsing failed.\n\nNote that while a single DHCP option can be at most 255 bytes, a DHCP\nmessage can contain multiple instances of the same option. The\nreceiver must concatenate all the occurrences according to RFC 3396\nand parse the resulting buffer.\n\nFixes: 6adade6f21d5 ('dhcp: add nettools dhcp4 client')\n","title":"dhcp: fix parsing of the search list option","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/dc3bb22633b970a87439851b9b303d56ed3c828b","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/dhcp/nm-dhcp-utils.c","src/core/dhcp/tests/test-dhcp-utils.c"],"removed":[]},{"id":"9d6b88fb5a7ed9323088d484389ce298313690dd","message":"core: fix Wi-Fi data rate tables\n\nFixes: f2b0092b5b23 ('wifi: parse BSS IEs for 80211n and 80211ac data rates')\n","title":"core: fix Wi-Fi data rate tables","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9d6b88fb5a7ed9323088d484389ce298313690dd","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-core-utils.c"],"removed":[]},{"id":"570ffd5872f2a251539adbe885c5453b2d2b6727","message":"libnm-core: fix documentation for NMSettingMatch functions\n\nFixes: 3a8e46f2a59a ('settings: add match for proc cmdline')\n","title":"libnm-core: fix documentation for NMSettingMatch functions","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/570ffd5872f2a251539adbe885c5453b2d2b6727","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-match.c"],"removed":[]},{"id":"8b02a643aac1e46bdc9032dc1d22ad38873553e2","message":"libnm-core: fix p-key validation for Infiniband connections\n\nverify() is setting an error without returning FALSE to make the\nvalidation fail. When the parent is set, the device is a Infiniband\npartition and it must have a p-key != -1.\n\nFixes: d595f7843e31 ('libnm: add libnm/libnm-core (part 1)')\n","title":"libnm-core: fix p-key validation for Infiniband connections","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8b02a643aac1e46bdc9032dc1d22ad38873553e2","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-infiniband.c"],"removed":[]},{"id":"a02ad9d234a6670d0e1b7f7cd788b4e5cf8704ea","message":"libnm-core: validate the ipvlan mode\n\nThe setting must reject unknown ipvlan modes.\n\nFixes: d238ff487b29 ('ipvlan: add support to IPVLAN interface')\n","title":"libnm-core: validate the ipvlan mode","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a02ad9d234a6670d0e1b7f7cd788b4e5cf8704ea","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/libnm-core-impl/nm-setting-ipvlan.c"],"removed":[]},{"id":"4a300d7b8388e535677f1079779fb42f7f8d2ecb","message":"l3cfg: fix logging message\n\nFix spacing in:\n\n acd[192.168.122.42, probing]: probing currently  stillnot possible\n                                                 ^^^^^^^^^\n\nFixes: b8f9d7b5dd11070ecb51b1aa5f4a4f6ad15fc0b5\n","title":"l3cfg: fix logging message","timestamp":"2025-07-11T09:01:21+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4a300d7b8388e535677f1079779fb42f7f8d2ecb","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-l3cfg.c"],"removed":[]}],"total_commits_count":16,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}