{"object_kind":"push","event_name":"push","before":"e1c22d90f41270995a3da9947d317cf663c7aef0","after":"5cd9f04007485488f96b5a417e6180bf58781be5","ref":"refs/heads/lr/ovs-generic","ref_protected":false,"checkout_sha":"5cd9f04007485488f96b5a417e6180bf58781be5","message":null,"user_id":1031,"user_name":"Lubomir Rintel","user_username":"lkundrak","user_email":"","user_avatar":"https://secure.gravatar.com/avatar/0c78b09297e4f43bda3282627ada927e031aabd945d9a02df75ae525a18952a8?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"43bcfbcdf5e255544adee3d02d0e98efa088c5d3","message":"cli: drop _NMC_RL_STARTUPHOOK_ARGS\n\nFixes incompatible pointer types warning, which became an error in\nnewer compilers (e.g., https://bugs.gentoo.org/938249).\n\nModern libedit versions use the same type signature as readline for\nrl_startup_hook, both declare\n\ntypedef int\t rl_hook_func_t(void)\n\nThis essentially reverts f47d55fc66bb (\"cli: Fix for rl_startup_hook\nfunction signatures mismatch (-lreadline vs -ledit)\").\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2082\n","title":"cli: drop _NMC_RL_STARTUPHOOK_ARGS","timestamp":"2025-05-20T09:54:31+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/43bcfbcdf5e255544adee3d02d0e98efa088c5d3","author":{"name":"Florian Schmaus","email":"flo@geekplace.eu"},"added":[],"modified":["src/nmcli/agent.c","src/nmcli/common.c","src/nmcli/common.h"],"removed":[]},{"id":"ccd9431e82ecb1653e4fb22116195d9eada1a3e5","message":"device: update L3 if connectivity changes in IP_CHECK/SECONDARIES\n\nIf connectivity goes from/to FULL, the penalization of default route metric\nmay change. For this reason we re-commit L3 configuration if the\nconnectivity changes while the device is ACTIVATED.\n\nHowever, there are more device states that need consideration:\nIP_CHECK and SECONDARIES, that happen between initial configuration on\nIP_CONFIG and removal when the device goes DEACTIVATING.\n\nThis should fix the issue encountered here:\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2070\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2212\n","title":"device: update L3 if connectivity changes in IP_CHECK/SECONDARIES","timestamp":"2025-05-22T11:18:36+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ccd9431e82ecb1653e4fb22116195d9eada1a3e5","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"a27c304fe46d462d09b7fd62dad972d1cf38c889","message":"ovs/factory: improve logging\n\nBe clearer about the progress of creating the device and ways it can end\nup failing.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2207\n","title":"ovs/factory: improve logging","timestamp":"2025-05-22T11:23:42+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/a27c304fe46d462d09b7fd62dad972d1cf38c889","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/core/devices/ovs/nm-ovs-factory.c"],"removed":[]},{"id":"ffe217bc621ee7ce728c796c74d6861d7d86c547","message":"manager: note if we see an openvswitch link without a plugin\n\nAdd Open VSwitch to link types that are supported by a plugin.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2207\n","title":"manager: note if we see an openvswitch link without a plugin","timestamp":"2025-05-22T11:23:42+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ffe217bc621ee7ce728c796c74d6861d7d86c547","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/core/nm-manager.c"],"removed":[]},{"id":"5cd9f04007485488f96b5a417e6180bf58781be5","message":"ovs/factory: fix manager-initiated device creation\n\nThe Open VSwitch interfaces have corresponding platform links. When an\nOpen VSwitch interface is created while NetworkManager is running, the\nOVS factory usually sees an OVSDB entry appear first, then creates a\nNMDevice. After that, when a platform link appears, the device is\nalready there.\n\nUpon a (re-)start, the link might be seen first, and then things\ngo south. The OVS factory rejects the device, which results in Generic\ndevice being created instead. Another device, this time of an\nappropriate is created for the same link once the OVSDB entry is seen.\n\nNeedless to say, with two NMDevices for the same platform link existing,\nno end of mayhem ensues (an assertion is tripped).\n\nResolves: https://issues.redhat.com/browse/NMT-1634\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2207\n","title":"ovs/factory: fix manager-initiated device creation","timestamp":"2025-05-22T11:23:42+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/5cd9f04007485488f96b5a417e6180bf58781be5","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["src/core/devices/ovs/nm-ovs-factory.c"],"removed":[]}],"total_commits_count":5,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}