{"object_kind":"push","event_name":"push","before":"326f25c0f62e92d34452e631dee2e81ac46e60af","after":"2dd3466a78eaefe3646eb728e806a0f3fe175553","ref":"refs/heads/lr/systemd-unit-lockdown","ref_protected":false,"checkout_sha":"2dd3466a78eaefe3646eb728e806a0f3fe175553","message":null,"user_id":1031,"user_name":"Lubomir Rintel","user_username":"lkundrak","user_email":"","user_avatar":"https://secure.gravatar.com/avatar/0c78b09297e4f43bda3282627ada927e031aabd945d9a02df75ae525a18952a8?s=80&d=identicon","project_id":411,"project":{"id":411,"name":"NetworkManager","description":"NetworkManager — network management daemon","web_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","avatar_url":"https://gitlab.freedesktop.org/uploads/-/system/project/avatar/411/nm_logo.png","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","namespace":"NetworkManager","visibility_level":20,"path_with_namespace":"NetworkManager/NetworkManager","default_branch":"main","ci_config_path":"","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git"},"commits":[{"id":"d26714481dc5dd2b8e32d4c931f8712962a768c5","message":"initrd: fix crash in the NBFT parser\n\nThe shared library handle is not initialized when there are no NBFT\nentries.\n\nFixes: 1cb0635d0801 ('initrd: add new NBFT parser')\n","title":"initrd: fix crash in the NBFT parser","timestamp":"2025-04-30T09:24:50+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d26714481dc5dd2b8e32d4c931f8712962a768c5","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-nbft-reader.c"],"removed":[]},{"id":"4f849c74b5ae62cd6e1a1da4dbf3612731e7c1e1","message":"release: bump version to 1.53.4 (development)\n","title":"release: bump version to 1.53.4 (development)","timestamp":"2025-05-02T16:19:35+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4f849c74b5ae62cd6e1a1da4dbf3612731e7c1e1","author":{"name":"Vladimír Beneš","email":"vbenes@redhat.com"},"added":[],"modified":["meson.build"],"removed":[]},{"id":"f67ec0ddf40670f1c3b516a61ba373f4c3b544fe","message":"Revert \"release: bump version to 1.53.4 (development)\"\n\nThis reverts commit 4f849c74b5ae62cd6e1a1da4dbf3612731e7c1e1","title":"Revert \"release: bump version to 1.53.4 (development)\"","timestamp":"2025-05-02T14:43:12+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/f67ec0ddf40670f1c3b516a61ba373f4c3b544fe","author":{"name":"Vladimír Beneš","email":"benesv@email.cz"},"added":[],"modified":["meson.build"],"removed":[]},{"id":"64a4c2271a9003f80076e8b54e47339b52522fd7","message":"release: bump version to 1.53.4 (development)\n","title":"release: bump version to 1.53.4 (development)","timestamp":"2025-05-02T16:46:08+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/64a4c2271a9003f80076e8b54e47339b52522fd7","author":{"name":"Vladimír Beneš","email":"vbenes@redhat.com"},"added":[],"modified":["meson.build"],"removed":[]},{"id":"6f1437b79e4d3c695e2ce65e3c8bddfa8c2a66c6","message":"libnm: add ethtool fec backported symbols from 1.50.4\n\nAdd to main branch ethtool fec symbols that were backported to 1.50.4 to\nallow seamless upgrading from 1.50 to 1.54.\n","title":"libnm: add ethtool fec backported symbols from 1.50.4","timestamp":"2025-05-06T13:33:30+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6f1437b79e4d3c695e2ce65e3c8bddfa8c2a66c6","author":{"name":"Wen Liang","email":"liangwen12year@gmail.com"},"added":[],"modified":["src/libnm-client-impl/libnm.ver","src/libnm-client-impl/nm-client.c"],"removed":[]},{"id":"799a7a432a864e09bf740ee3bd2bd46718e11760","message":"libnm: add ethtool fec backported symbols from 1.48.18\n\nAdd to main branch ethtool fec symbols that were backported to 1.48.18 to\nallow seamless upgrading from 1.48 to 1.54.\n","title":"libnm: add ethtool fec backported symbols from 1.48.18","timestamp":"2025-05-06T13:33:30+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/799a7a432a864e09bf740ee3bd2bd46718e11760","author":{"name":"Wen Liang","email":"liangwen12year@gmail.com"},"added":[],"modified":["src/libnm-client-impl/libnm.ver","src/libnm-client-impl/nm-client.c"],"removed":[]},{"id":"5b25bc4f9db4960a619a622107bb110b6c98b6a8","message":"libnm: add ethtool fec backported symbols from 1.46.8\n\nAdd to main branch ethtool fec symbols that were backported to 1.46.8 to\nallow seamless upgrading from 1.46 to 1.54.\n","title":"libnm: add ethtool fec backported symbols from 1.46.8","timestamp":"2025-05-06T13:33:30+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/5b25bc4f9db4960a619a622107bb110b6c98b6a8","author":{"name":"Wen Liang","email":"liangwen12year@gmail.com"},"added":[],"modified":["src/libnm-client-impl/libnm.ver","src/libnm-client-impl/nm-client.c"],"removed":[]},{"id":"26d4bc9d32d5a86452e67ad6ef81f82684fcfded","message":"merge: branch 'wl/ethtool_fec_backport_symbol'\n\nlibnm: add ethtool fec backported symbols from 1.50.4\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2198","title":"merge: branch 'wl/ethtool_fec_backport_symbol'","timestamp":"2025-05-06T13:35:39+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/26d4bc9d32d5a86452e67ad6ef81f82684fcfded","author":{"name":"Wen Liang","email":"liangwen12year@gmail.com"},"added":[],"modified":["src/libnm-client-impl/libnm.ver","src/libnm-client-impl/nm-client.c"],"removed":[]},{"id":"3d1b55047bf54a772a750ac875360156906f3807","message":"ci: update supported distros\n","title":"ci: update supported distros","timestamp":"2025-05-13T11:39:05+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3d1b55047bf54a772a750ac875360156906f3807","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":[".gitlab-ci.yml",".gitlab-ci/config.yml",".gitlab-ci/distros-info.yml"],"removed":[]},{"id":"bcbe386823ef0866e7c4e44e2708e897ef803a03","message":"all: code format\n","title":"all: code format","timestamp":"2025-05-13T11:43:33+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/bcbe386823ef0866e7c4e44e2708e897ef803a03","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/platform/nm-fake-platform.c","src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c","src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c","src/libnm-client-impl/nm-client.c","src/libnm-core-impl/nm-keyfile.c","src/libnm-core-impl/tests/test-general.c","src/libnm-glib-aux/nm-hash-utils.h","src/libnm-glib-aux/nm-test-utils.h","src/libnm-log-core/nm-logging.c","src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nmp-object.c","src/nm-dispatcher/nm-dispatcher.c"],"removed":[]},{"id":"9e585b6cdcec83f096cd9feeacdcc505408b4e5d","message":"merge: branch 'ih/distros-update'\n\nci: update supported distros\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2202","title":"merge: branch 'ih/distros-update'","timestamp":"2025-05-13T13:30:05+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9e585b6cdcec83f096cd9feeacdcc505408b4e5d","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":[".gitlab-ci.yml",".gitlab-ci/config.yml",".gitlab-ci/distros-info.yml","src/core/platform/nm-fake-platform.c","src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c","src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c","src/libnm-client-impl/nm-client.c","src/libnm-core-impl/nm-keyfile.c","src/libnm-core-impl/tests/test-general.c","src/libnm-glib-aux/nm-hash-utils.h","src/libnm-glib-aux/nm-test-utils.h","src/libnm-log-core/nm-logging.c","src/libnm-platform/nm-linux-platform.c","src/libnm-platform/nmp-object.c","src/nm-dispatcher/nm-dispatcher.c"],"removed":[]},{"id":"aeaf8ca23c49cd0c90a692771697abf1a62796d2","message":"nm-initrd-generator: fix IPv6 with square brackets in bond options\n\nIf any bond option contains an IPv6 address it needs to be enclosed with\n[]. Otherwise the ':' separators from the IP address can be confused\nwith the ':' separators from the 'bond=' cmdline arguments.\n\nHowever, the square brackets were ignored:\n    $ nm-initrd-generator -s \"bond=bond0:eth0,eth1:ns_ip6_target=[FC08::789:1:0:0:3]\"\n    NetworkManager-Message: 08:46:55.114: <warn>  [1745498815.1146] cmdline-reader: Ignoring invalid bond option: \"ns_ip6_target\" = \"[FC08\": '[FC08' is not a valid IPv6 address for 'ns_ip6_target' option\n    NetworkManager-Message: 08:46:55.114: <warn>  [1745498815.1148] cmdline-reader: Ignoring extra: '789:1:0:0:3]'.\n\nThe opening '[' was only being considered if it was the first character\nin `get_word`. Fix it and consider it if it's in the middle too.\n\nIf the brackets are used first and last, directly remove them as it is what\nmost callers expect. However, if it's in the middle there is no reasonable\nway to remove them, so don't do it. Instead, the caller will have to consider\nthis possibility when processing the content.\n\nFixes: ecc074b2f8a6 ('initrd: add command line parser')\nFixes https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1755\n","title":"nm-initrd-generator: fix IPv6 with square brackets in bond options","timestamp":"2025-05-14T07:35:31+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/aeaf8ca23c49cd0c90a692771697abf1a62796d2","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"6f6bb17a28e7247bfae8794f622b6855440b53e1","message":"nm-initrd-generator: fix ignored prefix for IPv6 address with brackets\n\nWhen defining an IPv6 address with square brackets and prefix, like\n[dead::beef]/64, the prefix was silently ignored. The address was\naccepted only accidentally, because get_word replaced ']' with '\\0' so\nit resulted in a valid IPv6 address string, but without the prefix.\n\nThe previous commit has fixed get_word with better logic to handle the\nsquare brackets, uncovering this issue.\n\nFix it by explicitly splitting IP addresses and prefixes in\nreader_parse_ip so we get a valid address and prefix.\n\nAlso, use a prefix different to 64 in the test test_if_ip6_manual. 64 is\nthe default one, making that the test passed despite the defined prefix\nwas actually ignored.\n\nFixes: ecc074b2f8a6 ('initrd: add command line parser')\n","title":"nm-initrd-generator: fix ignored prefix for IPv6 address with brackets","timestamp":"2025-05-14T07:35:31+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6f6bb17a28e7247bfae8794f622b6855440b53e1","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"34255b26922d9555cd3341f444087c8e81b0a21e","message":"merge: branch 'ih/initrd-fix-bond-ip6'\n\nnm-initrd-generator: fix IPv6 with square brackets in bond options\n\nCloses #1755 and #1731\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2197","title":"merge: branch 'ih/initrd-fix-bond-ip6'","timestamp":"2025-05-14T05:36:37+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/34255b26922d9555cd3341f444087c8e81b0a21e","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/nm-initrd-generator/nmi-cmdline-reader.c","src/nm-initrd-generator/tests/test-cmdline-reader.c"],"removed":[]},{"id":"94595332c454384cd67ae6ab6e54e3684bc6a97a","message":"core: virtual devices can be available without a parent set\n\nWhen calling to nm_device_is_available, the device types that requires a\nparent like VLAN or MACVLAN checks that their parent exists.\n\nnm_device_is_available is a function to check if the device is available\nto activate a connection, so it makes sense that if the parent is not\npresent it can't be activated.\n\nHowever, this is wrong for 2 reasons:\n1. Most of they are virtual devices that might be unrealized when\n   checking its availability. If they're unrealized, their parent hasn't\n   been set yet.\n2. Even if they're realized, their current parent might not be the one\n   that is defined in the connection that is being activated.\n\nThis is causing that unrealized devices are not being activated as ports\nbecause nm_manager_get_best_device_for_connection thinks that they are\nnot available.\n\nGet rid of these checks for the parent in the is_available callbacks.\n\nFixes: ba86c208e0aa ('Revert \"core: prevent the activation of unavailable OVS interfaces only\"')\nFixes: 774badb1519a ('core: prevent the activation of unavailable devices')\n","title":"core: virtual devices can be available without a parent set","timestamp":"2025-05-14T05:42:19+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/94595332c454384cd67ae6ab6e54e3684bc6a97a","author":{"name":"Íñigo Huguet","email":"ihuguet@redhat.com"},"added":[],"modified":["src/core/devices/nm-device-6lowpan.c","src/core/devices/nm-device-ipvlan.c","src/core/devices/nm-device-macsec.c","src/core/devices/nm-device-macvlan.c","src/core/devices/nm-device-vlan.c"],"removed":[]},{"id":"892e816a9defd82406ca597ef0d826c3f183f92a","message":"merge: branch 'ih/unrealized-parents'\n\ncore: virtual devices can be available without a parent\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2203","title":"merge: branch 'ih/unrealized-parents'","timestamp":"2025-05-14T05:42:36+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/892e816a9defd82406ca597ef0d826c3f183f92a","author":{"name":"Íñigo Huguet","email":"inigohuguet@hotmail.com"},"added":[],"modified":["src/core/devices/nm-device-6lowpan.c","src/core/devices/nm-device-ipvlan.c","src/core/devices/nm-device-macsec.c","src/core/devices/nm-device-macvlan.c","src/core/devices/nm-device-vlan.c"],"removed":[]},{"id":"fd3eccfb1612a3bac87232e1cbaabc10da80c302","message":"device: update the external-down unmanaged flag on port attach/release\n\nA device has the \"external-down\" unmanaged flag when:\n\n  !is-created-by-nm AND (!is-up OR (!has-address AND !is-controller))\n\nWhen the \"is-up\" or the \"has-address\" conditions change, we properly update\nthe unmanaged flag by calling _dev_unmanaged_check_external_down() in\n_dev_l3_cfg_notify_cb(PLATFORM_CHANGE_ON_IDLE).\n\nThe \"is-controller\" condition changes when another link indicates the\ncurrent device as controller. We currently don't update the unmanaged flag\nwhen that happens and so it's possible that the device stays unmanaged even\nif it has a port. This can be easily reproduced by running this commands:\n\n    ip link add veth0 type veth peer name veth1\n    ip link add vrf0 type vrf table 10\n    ip link set vrf0 up\n    ip link set veth0 master vrf0\n\nSometimes, the device shows as \"unmanaged\" instead of \"connected\n(externally)\".\n\nFix this by re-evaluating the \"external-down\" unmanaged flags on the\ncontroller when a port is attached or detached.\n\nFixes: c3586ce01a5b ('device: consider a device with slaves configured')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2209\n","title":"device: update the external-down unmanaged flag on port attach/release","timestamp":"2025-05-15T17:22:39+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/fd3eccfb1612a3bac87232e1cbaabc10da80c302","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/devices/nm-device.c"],"removed":[]},{"id":"c1350f40bdc769514f637b4b6754c4ff3ef67b66","message":"ip-config: fix crash in DNS options evaluation\n\nFixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration')\n","title":"ip-config: fix crash in DNS options evaluation","timestamp":"2025-05-16T09:41:03+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c1350f40bdc769514f637b4b6754c4ff3ef67b66","author":{"name":"Beniamino Galvani","email":"bgalvani@redhat.com"},"added":[],"modified":["src/core/nm-ip-config.c"],"removed":[]},{"id":"dd7252ff0c98fa1eed5c0e5a7b9ebcb63aef93a2","message":"merge: branch 'bg/ip-config-crash'\n\nip-config: fix crash in DNS options evaluation\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2210","title":"merge: branch 'bg/ip-config-crash'","timestamp":"2025-05-16T15:36:08+00:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/dd7252ff0c98fa1eed5c0e5a7b9ebcb63aef93a2","author":{"name":"Gris Ge","email":"fge@redhat.com"},"added":[],"modified":["src/core/nm-ip-config.c"],"removed":[]},{"id":"2dd3466a78eaefe3646eb728e806a0f3fe175553","message":"data/NetworkManager.service: restrict the unit some more\n\nThis adds some low-hanging food to improve our score with \"systemd-analyze\nsecurity\" by one point:\n\nBefore:\n  → Overall exposure level for NetworkManager.service: 7.8 EXPOSED 🙁\n\nAfter:\n  → Overall exposure level for NetworkManager.service: 6.8 MEDIUM 😐\n\nNothing particularly impactful here: we still got DAC_OVERRIDE, we still\ncan insert loadable modules (as opposed to relying on autoload) and\nread user home directories. But there's a slight chance this may save\nour butts one day, who knows.\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2062\n","title":"data/NetworkManager.service: restrict the unit some more","timestamp":"2025-05-19T16:07:17+02:00","url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/2dd3466a78eaefe3646eb728e806a0f3fe175553","author":{"name":"Lubomir Rintel","email":"lkundrak@v3.sk"},"added":[],"modified":["data/NetworkManager.service.in"],"removed":[]}],"total_commits_count":109,"push_options":{},"repository":{"name":"NetworkManager","url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","description":"NetworkManager — network management daemon","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","git_http_url":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git","git_ssh_url":"git@ssh.gitlab.freedesktop.org:NetworkManager/NetworkManager.git","visibility_level":20}}