This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file OPEN-SANS-LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/clamav See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: clamav-devel. Does not provide -static: clamav-devel. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "*No copyright* Apache License 2.0", "curl License", "MIT License", "University of Illinois/NCSA Open Source License", "*No copyright* Public domain", "BSD 3-Clause License", "*No copyright* zlib License", "GNU General Public License v2.0 or later", "Boost Software License 1.0", "*No copyright* GNU General Public License v2.0 or later", "Apache License 2.0", "BSD 2-Clause License", "zlib License", "Apache License 2.0 and/or GNU General Public License, Version 2", "NTP License", "ISC License", "GNU General Public License v3.0 or later", "*No copyright* GNU Lesser General Public License", "*No copyright* MIT License", "BSD 3-Clause License and/or GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v2.1 or later", "GNU General Public License, Version 2 and/or libtiff License", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Mass Ave)]", "*No copyright* GNU General Public License, Version 2", "BSD 0-Clause License", "*No copyright* The Unlicense", "*No copyright* Mozilla Public License 2.0", "Apache License 2.0 and/or MIT License", "*No copyright* Apache License (v2.0) or MIT license", "Apache License (v2.0) or MIT license and/or BSD 3-Clause License", "Apache License (v2.0) or MIT license", "Apache License 2.0 and/or BSD 3-Clause License", "*No copyright* Boost Software License 1.0", "Unicode License Agreement - Data Files and Software (2016)", "SIL Open Font License 1.1", "Apache License 2.0 and/or Boost Software License 1.0". 6963 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/clamav/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/clamav [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config %verify(not size md5 mtime) /var/lib/clamav/*.cvd [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 294752 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in clamav, clamav-freshclam, clamd, clamav-milter [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in clamav- filesystem , clamav-lib , clamav-devel , clamav-data , clamav- freshclam , clamd , clamav-milter [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Scriptlets must be sane, if used. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: clamav-1.4.3-3.fc42.i686.rpm clamav-filesystem-1.4.3-3.fc42.noarch.rpm clamav-lib-1.4.3-3.fc42.i686.rpm clamav-devel-1.4.3-3.fc42.i686.rpm clamav-data-1.4.3-3.fc42.noarch.rpm clamav-doc-1.4.3-3.fc42.noarch.rpm clamav-freshclam-1.4.3-3.fc42.i686.rpm clamd-1.4.3-3.fc42.i686.rpm clamav-milter-1.4.3-3.fc42.i686.rpm clamav-1.4.3-3.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb37pim4r')] checks: 32, packages: 10 clamav-milter.i686: W: tmpfile-not-in-filelist /run/clamav-milter clamd.i686: W: tmpfile-not-in-filelist /run/clamd.scan clamav-devel.i686: E: static-library-without-debuginfo /usr/lib/libclamav_rust.a clamav-data.noarch: E: spelling-error ('cron', '%description -l en_US cron -> corn, con, crone') clamav-devel.i686: E: spelling-error ('headerfiles', '%description -l en_US headerfiles -> header files, header-files, leaderless') clamd.i686: E: spelling-error ('clamav', '%description -l en_US clamav -> clam av, clam-av, clam') clamd.i686: E: spelling-error ('milter', '%description -l en_US milter -> molter, miler, miter') clamav.spec:601: W: shared-dir-glob-in-files %{_includedir}/* clamav-milter.i686: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/clamav-milter.conf clamd.i686: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/clamd.scan.conf clamav-filesystem.noarch: W: only-non-binary-in-usr-lib clamav-data.noarch: W: non-standard-uid /var/lib/clamav/bytecode.cvd clamupdate clamav-data.noarch: W: non-standard-uid /var/lib/clamav/daily.cvd clamupdate clamav-data.noarch: W: non-standard-uid /var/lib/clamav/main.cvd clamupdate clamav-filesystem.noarch: W: non-standard-uid /var/lib/clamav clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/bytecode.cld clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/bytecode.cvd clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/daily.cld clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/daily.cvd clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/freshclam.dat clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/main.cld clamupdate clamav-freshclam.i686: W: non-standard-uid /var/lib/clamav/main.cvd clamupdate clamav-data.noarch: W: non-standard-gid /var/lib/clamav/bytecode.cvd clamupdate clamav-data.noarch: W: non-standard-gid /var/lib/clamav/daily.cvd clamupdate clamav-data.noarch: W: non-standard-gid /var/lib/clamav/main.cvd clamupdate clamav-filesystem.noarch: W: non-standard-gid /var/lib/clamav clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/bytecode.cld clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/bytecode.cvd clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/daily.cld clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/daily.cvd clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/freshclam.dat clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/main.cld clamupdate clamav-freshclam.i686: W: non-standard-gid /var/lib/clamav/main.cvd clamupdate clamav.i686: E: non-standard-dir-perm /var/spool/quarantine 750 clamav-freshclam.i686: E: non-readable /etc/freshclam.conf 600 clamav-devel.i686: W: no-manual-page-for-binary clamav-config clamav-data.noarch: W: no-documentation clamav-devel.i686: W: no-documentation clamav-filesystem.noarch: W: no-documentation clamav-lib.i686: W: no-documentation clamav.i686: E: missing-call-to-setgroups-before-setuid /usr/bin/clamscan clamav.spec:797: W: macro-in-%changelog %{buildroot} clamav.spec:824: W: macro-in-%changelog %_sysconfdir clamav.spec:824: W: macro-in-%changelog %freshclamlog clamav.spec:938: W: macro-in-%changelog %freshclamlog clamav.spec: W: invalid-url Source0: clamav-1.4.3-norar.tar.xz clamav.i686: E: incorrect-fsf-address /usr/share/licenses/clamav/COPYING/COPYING.LGPL clamav-devel.i686: E: incorrect-fsf-address /usr/include/clamav-types-32.h clamav-devel.i686: E: incorrect-fsf-address /usr/include/clamav-version.h clamav-devel.i686: E: incorrect-fsf-address /usr/include/clamav.h clamav-devel.i686: E: incorrect-fsf-address /usr/include/libfreshclam.h clamav-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/clamav-doc/COPYING/COPYING.LGPL clamav-doc.noarch: E: files-duplicated-waste 187266 clamav-doc.noarch: W: files-duplicate /usr/share/doc/clamav/html/FontAwesome/fonts/fontawesome-webfont.ttf /usr/share/doc/clamav/html/FontAwesome/fonts/FontAwesome.ttf clamav-doc.noarch: W: files-duplicate /usr/share/doc/clamav/html/index.html /usr/share/doc/clamav/html/Introduction.html clamav-data.noarch: W: dangerous-command-in-%post rm clamd.i686: W: dangerous-command-in-%post ln clamav-data.noarch: W: conffile-without-noreplace-flag /var/lib/clamav/bytecode.cvd clamav-data.noarch: W: conffile-without-noreplace-flag /var/lib/clamav/daily.cvd clamav-data.noarch: W: conffile-without-noreplace-flag /var/lib/clamav/main.cvd 10 packages and 0 specfiles checked; 15 errors, 45 warnings, 84 filtered, 15 badness; has taken 13.3 s Rpmlint (debuginfo) ------------------- Checking: clamav-lib-debuginfo-1.4.3-3.fc42.i686.rpm clamav-freshclam-debuginfo-1.4.3-3.fc42.i686.rpm clamav-milter-debuginfo-1.4.3-3.fc42.i686.rpm clamav-debuginfo-1.4.3-3.fc42.i686.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplev3anw7')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 47 filtered, 0 badness; has taken 5.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "clamav-freshclam". (none): E: there is no installed rpm "clamav-freshclam-debuginfo". (none): E: there is no installed rpm "clamav-lib". (none): E: there is no installed rpm "clamav-lib-debuginfo". (none): E: there is no installed rpm "clamav-filesystem". (none): E: there is no installed rpm "clamav-debuginfo". (none): E: there is no installed rpm "clamav-devel". (none): E: there is no installed rpm "clamav-milter-debuginfo". (none): E: there is no installed rpm "clamav-data". (none): E: there is no installed rpm "clamd". (none): E: there is no installed rpm "clamav". (none): E: there is no installed rpm "clamav-milter". (none): E: there is no installed rpm "clamav-doc". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 13 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- clamav (rpmlib, GLIBC filtered): /bin/sh clamav-filesystem clamav-lib data(clamav) filesystem(unmerged-sbin-symlinks) ld-linux.so.2 libc.so.6 libclamav.so.12 libclamav.so.12(CLAMAV_0.104.0) libclamav.so.12(CLAMAV_1.0.0) libclamav.so.12(CLAMAV_1.1.0) libclamav.so.12(CLAMAV_PRIVATE) libclamav.so.12(CLAMAV_PUBLIC) libcurl.so.4 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3) libgcc_s.so.1(GCC_4.2.0) libjson-c.so.5 libjson-c.so.5(JSONC_0.14) libm.so.6 libncurses.so.6 libtinfo.so.6 libz.so.1 libz.so.1(ZLIB_1.2.0.2) rtld(GNU_HASH) systemd clamav-filesystem (rpmlib, GLIBC filtered): config(clamav-filesystem) clamav-lib (rpmlib, GLIBC filtered): ld-linux.so.2 libbz2.so.1 libc.so.6 libclammspack.so.0 libcrypto.so.3 libcrypto.so.3(OPENSSL_3.0.0) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3) libgcc_s.so.1(GCC_4.2.0) libjson-c.so.5 libjson-c.so.5(JSONC_0.14) libm.so.6 libpcre2-8.so.0 libxml2.so.2 libxml2.so.2(LIBXML2_2.4.30) libxml2.so.2(LIBXML2_2.5.0) libxml2.so.2(LIBXML2_2.5.2) libxml2.so.2(LIBXML2_2.5.7) libxml2.so.2(LIBXML2_2.6.0) libz.so.1 rtld(GNU_HASH) clamav-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config /usr/bin/sh clamav-filesystem clamav-lib libclamav.so.12 libclammspack.so.0 libfreshclam.so.3 openssl-devel clamav-data (rpmlib, GLIBC filtered): /bin/sh clamav-filesystem config(clamav-data) clamav-doc (rpmlib, GLIBC filtered): clamav-filesystem clamav-freshclam (rpmlib, GLIBC filtered): /bin/sh clamav-filesystem clamav-lib config(clamav-freshclam) ld-linux.so.2 libc.so.6 libclamav.so.12 libclamav.so.12(CLAMAV_1.0.0) libclamav.so.12(CLAMAV_PRIVATE) libclamav.so.12(CLAMAV_PUBLIC) libcrypto.so.3 libcrypto.so.3(OPENSSL_3.0.0) libcurl.so.4 libfreshclam.so.3 libfreshclam.so.3(FRESHCLAM_PUBLIC) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.3) libgcc_s.so.1(GCC_4.2.0) libm.so.6 libz.so.1 rtld(GNU_HASH) clamd (rpmlib, GLIBC filtered): /bin/sh clamav-filesystem clamav-lib coreutils data(clamav) filesystem(unmerged-sbin-symlinks) libc.so.6 libclamav.so.12 libclamav.so.12(CLAMAV_1.1.0) libclamav.so.12(CLAMAV_PRIVATE) libclamav.so.12(CLAMAV_PUBLIC) libsystemd.so.0 libsystemd.so.0(LIBSYSTEMD_209) rtld(GNU_HASH) clamav-milter (rpmlib, GLIBC filtered): /bin/sh clamav-filesystem config(clamav-milter) filesystem(unmerged-sbin-symlinks) group(clamscan) libc.so.6 libclamav.so.12 libclamav.so.12(CLAMAV_PRIVATE) libmilter.so.1.0 rtld(GNU_HASH) Provides -------- clamav: clamav clamav(x86-32) clamav-filesystem: clamav-filesystem config(clamav-filesystem) group(clamupdate) group(virusgroup) groupmember(clamupdate/virusgroup) user(clamupdate) clamav-lib: bundled(libmspack) clamav-lib clamav-lib(x86-32) libclamav.so.12 libclamav.so.12(CLAMAV_0.104.0) libclamav.so.12(CLAMAV_1.0.0) libclamav.so.12(CLAMAV_1.1.0) libclamav.so.12(CLAMAV_PRIVATE) libclamav.so.12(CLAMAV_PUBLIC) libclammspack.so.0 clamav-devel: clamav-devel clamav-devel(x86-32) pkgconfig(libclamav) clamav-data: clamav-data clamav-db config(clamav-data) data(clamav) clamav-doc: clamav-doc clamav-freshclam: clamav-data-empty clamav-freshclam clamav-freshclam(x86-32) clamav-update config(clamav-freshclam) data(clamav) libfreshclam.so.3 libfreshclam.so.3(FRESHCLAM_PRIVATE) libfreshclam.so.3(FRESHCLAM_PUBLIC) clamd: clamav-scanner-systemd clamav-server clamav-server-systemd clamd clamd(x86-32) group(clamscan) groupmember(clamscan/virusgroup) user(clamscan) clamav-milter: clamav-milter clamav-milter(x86-32) clamav-milter-systemd config(clamav-milter) group(clamilt) groupmember(clamilt/clamscan) groupmember(clamilt/virusgroup) user(clamilt) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name clamav --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-42-i686 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: PHP, Perl, Java, Ocaml, SugarActivity, Python, fonts, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH