This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* zlib License", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License, Version 3", "GNU Library General Public License v2 or later", "zlib License", "BSD 3-Clause License", "BSD 2-Clause License", "Apache License 2.0", "MIT License", "MIT License and/or zlib License", "Boost Software License 1.0", "Khronos License and/or MIT License", "GNU General Public License, Version 3", "BSD 2-clause FreeBSD License", "*No copyright* Public domain", "*No copyright* MIT License", "*No copyright* GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "GNU General Public License", "GNU Lesser General Public License v2.1 or later", "Public domain", "GNU General Public License, Version 2", "Apache License 2.0 and/or MIT License", "GNU General Public License v2.0 or later", "Creative Commons Attribution 3.0", "*No copyright* Mozilla Public License 2.0", "Mozilla Public License 2.0", "Apache License 2.0 and/or Khronos License and/or MIT License", "MIT License and/or The Unlicense", "MIT Open Group variant", "NTP License", "SIL Open Font License 1.1", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License, Version 2.1", "GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Mass Ave)]", "Khronos License", "Historical Permission Notice and Disclaimer - sell variant", "BSD 3-Clause License [generated file]", "SGI Free Software License B v2.0", "Apple MIT License", "BSD 3-Clause License and/or Mozilla Public License 2.0", "Boehm GC License and/or Mozilla Public License 2.0", "*No copyright* Apache License 2.0". 12983 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/openmw-git/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 258720 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2549760 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: openmw-git-0.49.0.36691-1.fc43.x86_64.rpm openmw-git-cs-0.49.0.36691-1.fc43.x86_64.rpm openmw-git-tools-0.49.0.36691-1.fc43.x86_64.rpm openmw-git-0.49.0.36691-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpeiujhqot')] checks: 32, packages: 4 openmw-git.x86_64: E: zero-length /etc/openmw/defaults-cs.bin openmw-git-tools.x86_64: W: summary-ended-with-dot Utility programs for OpenMW. openmw-git.x86_64: W: non-conffile-in-etc /etc/openmw/defaults-cs.bin openmw-git.x86_64: W: non-conffile-in-etc /etc/openmw/defaults.bin openmw-git.x86_64: W: non-conffile-in-etc /etc/openmw/gamecontrollerdb.txt openmw-git.x86_64: W: non-conffile-in-etc /etc/openmw/openmw.cfg openmw-git.x86_64: W: no-manual-page-for-binary openmw openmw-git.x86_64: W: no-manual-page-for-binary openmw-bulletobjecttool openmw-git.x86_64: W: no-manual-page-for-binary openmw-essimporter openmw-git.x86_64: W: no-manual-page-for-binary openmw-iniimporter openmw-git.x86_64: W: no-manual-page-for-binary openmw-launcher openmw-git.x86_64: W: no-manual-page-for-binary openmw-navmeshtool openmw-git.x86_64: W: no-manual-page-for-binary openmw-wizard openmw-git-cs.x86_64: W: no-manual-page-for-binary openmw-cs openmw-git-tools.x86_64: W: no-manual-page-for-binary bsatool openmw-git-tools.x86_64: W: no-manual-page-for-binary esmtool openmw-git-tools.x86_64: W: no-manual-page-for-binary niftest openmw-git-cs.x86_64: W: no-documentation openmw-git-tools.x86_64: W: no-documentation openmw-git.x86_64: W: files-duplicate /usr/share/pixmaps/openmw.png /usr/share/openmw/resources/openmw.png openmw-git.x86_64: W: files-duplicate /usr/share/openmw/resources/translations/wizard_de.qm /usr/share/openmw/resources/translations/launcher_de.qm openmw-git.x86_64: W: files-duplicate /usr/share/openmw/resources/vfs/mygui/openmw_mainmenu.skin.xml /usr/share/openmw/resources/vfs/mygui/openmw_dialogue_window.skin.xml openmw-git-cs.x86_64: W: desktopfile-without-binary /usr/share/applications/org.openmw.cs.desktop env openmw-git.x86_64: W: dangling-relative-symlink /usr/share/openmw/resources/vfs/fonts/DejaVuLGCSansMono.ttf ../../../../fonts/dejavu-lgc-sans-mono-fonts/DejaVuLGCSansMono.ttf 4 packages and 0 specfiles checked; 1 errors, 23 warnings, 20 filtered, 1 badness; has taken 8.6 s Rpmlint (debuginfo) ------------------- Checking: openmw-git-debuginfo-0.49.0.36691-1.fc43.x86_64.rpm openmw-git-tools-debuginfo-0.49.0.36691-1.fc43.x86_64.rpm openmw-git-cs-debuginfo-0.49.0.36691-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpekvqi0_u')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 38 filtered, 0 badness; has taken 43.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "openmw-git-cs". (none): E: there is no installed rpm "openmw-git-cs-debuginfo". (none): E: there is no installed rpm "openmw-git-debuginfo". (none): E: there is no installed rpm "openmw-git-tools-debuginfo". (none): E: there is no installed rpm "openmw-git-tools". (none): E: there is no installed rpm "openmw-git". ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://github.com/recastnavigation/recastnavigation/archive/c393777d26d2ff6519ac23612abf8af42678c9dd/recastnavigation-c393777d26d2ff6519ac23612abf8af42678c9dd.tar.gz : CHECKSUM(SHA256) this package : fa8b901651017b20a38996bbab2d205d244328ed11778b53224282e9884e6c91 CHECKSUM(SHA256) upstream package : fa8b901651017b20a38996bbab2d205d244328ed11778b53224282e9884e6c91 https://github.com/OpenMW/osg/archive/43faf6fa88bd236e0911a5340bfbcbc25b3a98d9/osg-43faf6fa88bd236e0911a5340bfbcbc25b3a98d9.tar.gz : CHECKSUM(SHA256) this package : 10b9bef6297ca328b70a94e53538c22f764795cfd3aad504a1db16df97d0950b CHECKSUM(SHA256) upstream package : 10b9bef6297ca328b70a94e53538c22f764795cfd3aad504a1db16df97d0950b https://github.com/bulletphysics/bullet3/archive/3.25/bullet3-3.25.tar.gz : CHECKSUM(SHA256) this package : c45afb6399e3f68036ddb641c6bf6f552bf332d5ab6be62f7e6c54eda05ceb77 CHECKSUM(SHA256) upstream package : c45afb6399e3f68036ddb641c6bf6f552bf332d5ab6be62f7e6c54eda05ceb77 https://gitlab.com/OpenMW/openmw/-/archive/master/openmw-master.tar.bz2 : CHECKSUM(SHA256) this package : 6e0981511fd3ce53d4da52e364680a21078041146db93155dbb61494b5ca0f53 CHECKSUM(SHA256) upstream package : 6e0981511fd3ce53d4da52e364680a21078041146db93155dbb61494b5ca0f53 Requires -------- openmw-git (rpmlib, GLIBC filtered): dejavu-lgc-sans-mono-fonts libGL.so.1()(64bit) libMyGUIEngine.so.3.4.3()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libX11.so.6()(64bit) libXinerama.so.1()(64bit) libXrandr.so.2()(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libicui18n.so.76()(64bit) libicuuc.so.76()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libluajit-5.1.so.2()(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswresample.so.5()(64bit) libswresample.so.5(LIBSWRESAMPLE_5)(64bit) libswscale.so.8()(64bit) libswscale.so.8(LIBSWSCALE_8)(64bit) libunshield.so.1()(64bit) libyaml-cpp.so.0.8()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) openmw-git-cs (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libMyGUIEngine.so.3.4.3()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.9)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6OpenGLWidgets.so.6()(64bit) libQt6OpenGLWidgets.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libSDL2-2.0.so.0()(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libyaml-cpp.so.0.8()(64bit) libz.so.1()(64bit) openmw-git(x86-64) rtld(GNU_HASH) openmw-git-tools (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libboost_program_options.so.1.83.0()(64bit) libc.so.6()(64bit) libcollada-dom2.5-dp.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblz4.so.1()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) openmw-git(x86-64) rtld(GNU_HASH) Provides -------- openmw-git: application() application(org.openmw.launcher.desktop) bundled(OpenSceneGraph-OpenMW) bundled(bullet) bundled(fonts(DemonicLetters)) bundled(fonts(MysticCards)) bundled(recastnavigation) bundled(sol3) metainfo() metainfo(openmw.appdata.xml) openmw-git openmw-git(x86-64) openmw-git-cs: application() application(org.openmw.cs.desktop) openmw-git-cs openmw-git-cs(x86-64) openmw-git-tools: openmw-git-tools openmw-git-tools(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name openmw-git --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Python, Perl, SugarActivity, Java, R, PHP, Haskell, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH