class RuboCop::Cop::Lint::SelfAssignment
Checks for self-assignments.
@example
# bad foo = foo foo, bar = foo, bar Foo = Foo hash['foo'] = hash['foo'] obj.attr = obj.attr # good foo = bar foo, bar = bar, foo Foo = Bar hash['foo'] = hash['bar'] obj.attr = obj.attr2 # good (method calls possibly can return different results) hash[foo] = hash[foo]
@example AllowRBSInlineAnnotation:true
# good foo = foo #: Integer foo, bar = foo, bar #: Integer Foo = Foo #: Integer hash['foo'] = hash['foo'] #: Integer obj.attr = obj.attr #: Integer
Constants
- ASSIGNMENT_TYPE_TO_RHS_TYPE
- MSG
Public Instance Methods
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 67 def on_casgn(node) return unless node.rhs&.const_type? return if allow_rbs_inline_annotation? && rbs_inline_annotation?(node.rhs) add_offense(node) if node.namespace == node.rhs.namespace && node.short_name == node.rhs.short_name end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 55 def on_lvasgn(node) return unless node.rhs return if allow_rbs_inline_annotation? && rbs_inline_annotation?(node.rhs) rhs_type = ASSIGNMENT_TYPE_TO_RHS_TYPE[node.type] add_offense(node) if node.rhs.type == rhs_type && node.rhs.source == node.lhs.to_s end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 75 def on_masgn(node) first_lhs = node.lhs.assignments.first return if allow_rbs_inline_annotation? && rbs_inline_annotation?(first_lhs) add_offense(node) if multiple_self_assignment?(node) end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 82 def on_or_asgn(node) return if allow_rbs_inline_annotation? && rbs_inline_annotation?(node.lhs) add_offense(node) if rhs_matches_lhs?(node.rhs, node.lhs) end
Also aliased as: on_and_asgn
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 44 def on_send(node) return if allow_rbs_inline_annotation? && rbs_inline_annotation?(node.receiver) if node.method?(:[]=) handle_key_assignment(node) if node.arguments.size == 2 elsif node.assignment_method? handle_attribute_assignment(node) if node.arguments.size == 1 end end
Also aliased as: on_csend
Private Instance Methods
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 133 def allow_rbs_inline_annotation? cop_config['AllowRBSInlineAnnotation'] end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 118 def handle_attribute_assignment(node) first_argument = node.first_argument return unless first_argument.respond_to?(:arguments) && first_argument.arguments.empty? if first_argument.call_type? && node.receiver == first_argument.receiver && first_argument.method_name.to_s == node.method_name.to_s.delete_suffix('=') add_offense(node) end end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 107 def handle_key_assignment(node) value_node = node.arguments[1] if value_node.send_type? && value_node.method?(:[]) && node.receiver == value_node.receiver && !node.first_argument.call_type? && node.first_argument == value_node.first_argument add_offense(node) end end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 91 def multiple_self_assignment?(node) lhs = node.lhs rhs = node.rhs return false unless rhs.array_type? return false unless lhs.children.size == rhs.children.size lhs.children.zip(rhs.children).all? do |lhs_item, rhs_item| rhs_matches_lhs?(rhs_item, lhs_item) end end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 129 def rbs_inline_annotation?(node) processed_source.ast_with_comments[node].any? { |comment| comment.text.start_with?('#:') } end
Source
# File lib/rubocop/cop/lint/self_assignment.rb, line 102 def rhs_matches_lhs?(rhs, lhs) rhs.type == ASSIGNMENT_TYPE_TO_RHS_TYPE[lhs.type] && rhs.children.first == lhs.children.first end