class RuboCop::Cop::Style::NegatedIfElseCondition
Checks for uses of ‘if-else` and ternary operators with a negated condition which can be simplified by inverting condition and swapping branches.
@example
# bad if !x do_something else do_something_else end # good if x do_something_else else do_something end # bad !x ? do_something : do_something_else # good x ? do_something_else : do_something
Constants
- MSG
- NEGATED_EQUALITY_METHODS
Public Class Methods
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 41 def self.autocorrect_incompatible_with [Style::InverseMethods, Style::Not] end
Public Instance Methods
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 50 def on_if(node) return unless if_else?(node) return unless (condition = unwrap_begin_nodes(node.condition)) return if double_negation?(condition) || !negated_condition?(condition) return unless condition.arguments.size < 2 message = message(node) add_offense(node, message: message) do |corrector| unless corrected_ancestor?(node) correct_negated_condition(corrector, condition) swap_branches(corrector, node) @corrected_nodes ||= Set.new.compare_by_identity @corrected_nodes.add(node) end end end
rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 45 def on_new_investigation @corrected_nodes = nil end
Private Instance Methods
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 97 def correct_negated_condition(corrector, node) replacement = if node.negation_method? node.receiver.source else inverted_method = node.method_name.to_s.sub('!', '=') "#{node.receiver.source} #{inverted_method} #{node.first_argument.source}" end corrector.replace(node, replacement) end
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 93 def corrected_ancestor?(node) node.each_ancestor(:if).any? { |ancestor| @corrected_nodes&.include?(ancestor) } end
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 127 def else_range(node) if node.ternary? node.else_branch else range_between(node.loc.else.end_pos, node.loc.end.begin_pos) end end
Collect the entire else branch, including whitespace and comments
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 71 def if_else?(node) else_branch = node.else_branch !node.elsif? && else_branch && (!else_branch.if_type? || !else_branch.elsif?) end
rubocop:enable Metrics/AbcSize,Metrics/CyclomaticComplexity
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 118 def if_range(node) if node.ternary? node.if_branch else range_between(node.condition.source_range.end_pos, node.loc.else.begin_pos) end end
Collect the entire if branch, including whitespace and comments
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 87 def message(node) type = node.ternary? ? 'ternary' : 'if-else' format(MSG, type: type) end
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 82 def negated_condition?(node) node.send_type? && (node.negation_method? || NEGATED_EQUALITY_METHODS.include?(node.method_name)) end
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 109 def swap_branches(corrector, node) if node.if_branch.nil? corrector.remove(range_by_whole_lines(node.loc.else, include_final_newline: true)) else corrector.swap(if_range(node), else_range(node)) end end
Source
# File lib/rubocop/cop/style/negated_if_else_condition.rb, line 76 def unwrap_begin_nodes(node) node = node.children.first while node&.type?(:begin, :kwbegin) node end